drivers: comparator: Add Comparator support on Renesas RX #93694
+588
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_renesas
DNM (manifest)
quytranpzz
force-pushed
the
renesas_rx_lvd_support
branch
6 times, most recently
from
6018f8c to
c11e903
Compare
zephyrbot
added
area: Samples
zephyrbot
requested review from
duynguyenxa,
gmarull,
kartben,
KhiemNguyenT,
nashif,
soburi,
thaoluonguw and
thenguyenyf
thenguyenyf
reviewed
Aug 5, 2025
duynguyenxa
reviewed
Aug 7, 2025
quytranpzz
force-pushed
the
renesas_rx_lvd_support
branch
from
c11e903 to
d012894
Compare
github-actions
bot
added
the
DNM (manifest)
zephyrbot
requested review from
decsny,
dleach02,
khoa-nguyen-18,
manuargue and
mmahadevan108
quytranpzz
force-pushed
the
renesas_rx_lvd_support
branch
from
32de31c to
7f1fb14
Compare
zephyrbot
requested review from
bjarki-andreasen,
duynguyenxa,
ioannis-karachalios,
kartben and
soburi
quytranpzz
changed the title
quytranpzz
force-pushed
the
renesas_rx_lvd_support
branch
3 times, most recently
from
59e026a to
b71daf0
Compare
|
this is literally the 3rd PR I looked at in 15 minutes where NXP maintainer got pulled in despite no NXP files, please fix the MAINTAINER.yml |
duynguyenxa
requested changes
Sep 23, 2025
| @@ -0,0 +1,271 @@ | |||
| /* | |||
There was a problem hiding this comment.
@quytranpzz , This file name should be comparator_renesas_rx_lvd.c
There was a problem hiding this comment.
It's done. I updated the file name
drivers/comparator/CMakeLists.txt
Outdated
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_NRF_LPCOMP comparator_nrf_lpcomp.c) | ||
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_SHELL comparator_shell.c) | ||
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_RENESAS_RA comparator_renesas_ra.c) | ||
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_RENESAS_RX_LVD comparator_renesas_rx.c) |
There was a problem hiding this comment.
@quytranpzz , Please change file name to comparator_renesas_rx_lvd.c
Comment on lines
182
to
200
| #define LVD_IRQ_CONNECT() \ | ||
| do { \ | ||
| IF_ENABLED(DT_NODE_HAS_STATUS_OKAY(LVD0_NODE), ( \ | ||
| IRQ_CONNECT(DT_IRQN(LVD0_NODE), \ | ||
| DT_IRQ(LVD0_NODE, priority), \ | ||
| lvd_ch1_isr, \ | ||
| DEVICE_DT_GET(LVD0_NODE), \ | ||
| 0); \ | ||
| irq_enable(DT_IRQN(LVD0_NODE)); \ | ||
| )) \ | ||
| IF_ENABLED(DT_NODE_HAS_STATUS_OKAY(LVD1_NODE), ( \ | ||
| IRQ_CONNECT(DT_IRQN(LVD1_NODE), \ | ||
| DT_IRQ(LVD1_NODE, priority), \ | ||
| lvd_ch2_isr, \ | ||
| DEVICE_DT_GET(LVD1_NODE), \ | ||
| 0); \ | ||
| irq_enable(DT_IRQN(LVD1_NODE)); \ | ||
| )) \ | ||
| } while (0) |
There was a problem hiding this comment.
@quytranpzz , I think it would be better to add this as static inline function
e.g.
static inline void lvd_irq_connect(void)
{
#if DT_NODE_HAS_STATUS_OKAY(LVD0_NODE)
IRQ_CONNECT(DT_IRQN(LVD0_NODE), DT_IRQ(LVD0_NODE, priority), lvd_ch1_isr, DEVICE_DT_GET(LVD0_NODE), 0);
irq_enable(DT_IRQN(LVD0_NODE));
#endif
#if DT_NODE_HAS_STATUS_OKAY(LVD1_NODE)
IRQ_CONNECT(DT_IRQN(LVD1_NODE), DT_IRQ(LVD1_NODE, priority), lvd_ch2_isr, DEVICE_DT_GET(LVD1_NODE), 0);
irq_enable(DT_IRQN(LVD1_NODE));
#endif
}
There was a problem hiding this comment.
Thanks, I have updated it as a static inline function
Update the latest commit ID for HAL Renesas Signed-off-by: Quy Tran <[email protected]>
Add comparator support for Renesas RX with LVD Signed-off-by: Quy Tran <[email protected]>
Add DTS node for LVD support on RX130 Signed-off-by: Quy Tran <[email protected]>
Add a simple sample using Comparator API to monitor the voltage on Renesas boards Signed-off-by: Quy Tran <[email protected]>
quytranpzz
force-pushed
the
renesas_rx_lvd_support
branch
from
b71daf0 to
c49bac7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comparator driver support on Renesas RX130 using LVD peripheral.
This driver uses a voltage threshold as the negative input, while the positive input can be selected between Vcc or the CMPA pin.